Supplement Codacy with DeepSource#2454
Merged
Bibo-Joshi merged 30 commits intomasterfrom May 27, 2021
Merged
Conversation
Member
Author
|
DeepSource indeed found a number of things that can be improved. Large parts of those are "just" documentation improvements according to the google style guide, but since actually "officially" adhere to those (meaning: we say so in the contrib guide), I think this is a good opportunity to actually do so. I'll try & make the corresponding changes in the near future. |
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
Resolved issues in the following files via DeepSource Autofix: 1. tests/conftest.py 2. tests/test_bot.py 3. tests/test_commandhandler.py 4. tests/test_conversationhandler.py 5. tests/test_dispatcher.py 6. tests/test_filters.py 7. tests/test_inputmedia.py 8. tests/test_messagehandler.py 9. tests/test_official.py 10. tests/test_persistence.py
Merged
# Conflicts: # telegram/bot.py # telegram/ext/conversationhandler.py # telegram/ext/filters.py # telegram/utils/webhookhandler.py
# Conflicts: # tests/test_updater.py
8 tasks
starry-shivam
approved these changes
May 25, 2021
Member
starry-shivam
left a comment
There was a problem hiding this comment.
Changes looks good to me, great job for adding all those missing docs 👍
harshil21
reviewed
May 26, 2021
harshil21
approved these changes
May 26, 2021
Poolitzer
approved these changes
May 27, 2021
Member
Poolitzer
left a comment
There was a problem hiding this comment.
I like this PR, changes look good
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging:
Some notes:
DaysinJobQueue, as we don't really use it.