Merged
Conversation
Bibo-Joshi
reviewed
Apr 21, 2021
Member
There was a problem hiding this comment.
Cool stuff! 🦾 (I see succeeding tests ❤️ )
about flaky: tests that don't make a requests to TG shouldn't be flaky. the idea behind flaky is to make non-deterministic tests more stable. I can agree to the conversation timeout thingy, because timing is not always really deterministic but IISC the other two tests shouldn't be flaky and I don't recall them being unreliable for me …
Bibo-Joshi
reviewed
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the pytest-timeout plugin, since we have have patient_request_wrapper, which already handles timeout errors. Also stops tests from failing unnecessarily!