ChatMemberHandler example, ChatMemberUpdated.difference & utlitiy constants#2490
Merged
Bibo-Joshi merged 7 commits intomasterfrom Apr 30, 2021
Merged
ChatMemberHandler example, ChatMemberUpdated.difference & utlitiy constants#2490Bibo-Joshi merged 7 commits intomasterfrom
Bibo-Joshi merged 7 commits intomasterfrom
Conversation
Bibo-Joshi
commented
Apr 28, 2021
harshil21
reviewed
Apr 28, 2021
Member
harshil21
left a comment
There was a problem hiding this comment.
Good job! Found mostly spelling errors.
Poolitzer
requested changes
Apr 29, 2021
Member
Poolitzer
left a comment
There was a problem hiding this comment.
Very good, I love the example and difference is a great idea.
harshil21
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does three things:
ChatMemberUpdated.differenceas suggested by @harshil21 - the naming of the method is up for discussion, if you have other suggestions :)tg.constants/Updatewhich can be used to setallowed_updatesmore convenientlyChatMemberHandlerand above stuffpre-commit/pylint is failing locally for some reason. let's see how CI behaves.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
If relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION