Merged
Conversation
Bibo-Joshi
reviewed
May 14, 2021
Member
Author
|
There were many reasons why the game tests were failing -
Despite fixing this, there is still a chance that this can fail due to race conditions (many jobs running at once), so an Edit: Also removed an unnecessary game test. Onto the next test... |
Bibo-Joshi
reviewed
May 16, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
I admire your patience with the tests 👍
Member
|
changes look good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix tests like:
First two will be fixed when the tests actually fail and the error is printed to console
Checks will be run many times to expose the failing ones