BP.insert/replace_bot: Handle objects with __dict__ in __slots__#2561
Merged
Bibo-Joshi merged 2 commits intomasterfrom Jun 13, 2021
Merged
BP.insert/replace_bot: Handle objects with __dict__ in __slots__#2561Bibo-Joshi merged 2 commits intomasterfrom
Bibo-Joshi merged 2 commits intomasterfrom
Conversation
Member
|
what error is that fixing? |
Member
Author
|
@Poolitzer When an object has both slots and dict, currently the code handles dict and returns the changed object leaving the other slots unchanged |
Member
|
@Bibo-Joshi ahh, now I get it. Good found. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Never ending story 😬 Anyway, good that we didn't make a bug fix release yet