Merged
Conversation
harshil21
reviewed
Jun 26, 2021
Member
harshil21
left a comment
There was a problem hiding this comment.
scopes look good - one tiny doc fix.
Signed-off-by: starry69 <starry369126@outlook.com>
and add `delete_my_commands()`
…y.py also improved/fixed docs along the way
harshil21
reviewed
Jun 26, 2021
Bibo-Joshi
commented
Jun 26, 2021
harshil21
reviewed
Jun 26, 2021
Bibo-Joshi
commented
Jun 26, 2021
# Conflicts: # tests/test_bot.py
Signed-off-by: starry69 <starry369126@outlook.com>
Bibo-Joshi
commented
Jun 28, 2021
harshil21
reviewed
Jun 28, 2021
Signed-off-by: starry69 <starry369126@outlook.com>
Bibo-Joshi
commented
Jun 29, 2021
Bibo-Joshi
commented
Jun 29, 2021
Signed-off-by: starry69 <starry369126@outlook.com>
Member
Author
|
Note about slots: I had remove the test lines that @harshil21 pointed out, b/c we are adding new classes and I thought that we don't need to have |
harshil21
reviewed
Jun 29, 2021
Signed-off-by: starry69 <starry369126@outlook.com>
Signed-off-by: starry69 <starry369126@outlook.com>
This was referenced Jul 1, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BotCommandScope*is just for input, never output (at least for now), so we don't really need a properde_json. But I realized that only after I had implemented it … If you think it's superfluous, we can removeChecklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_id-> We need to deprecateChat.get_members_countin favor of a newChat.get_member_countand the same forkick_chat_member->ban_chat_member[ ] InMessagefor all methods that acceptchat_idandmessage_id[ ] For newMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id[ ] InCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variables[ ] Added new handlers for new update types[ ] Added new filters for new message (sub)typesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION[ ] Added logic for arbitrary callback data intg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message