add stacklevel parameter to set_new_attribute_deprecated#2574
Merged
Bibo-Joshi merged 2 commits intomasterfrom Jun 29, 2021
Merged
add stacklevel parameter to set_new_attribute_deprecated#2574Bibo-Joshi merged 2 commits intomasterfrom
set_new_attribute_deprecated#2574Bibo-Joshi merged 2 commits intomasterfrom
Conversation
Member
|
Ran a small test and noticed that it says e.g. "objects such as 'User'" instead of "objects such as 'telegram.User'" and for filters it will report name of the private class we use. I can live with both given that this warning will only be removed eventually and the latter is quite the edge case imo. Just wanted to note this before we go for merging … :) |
Member
Author
|
@Bibo-Joshi Yep, the user would mostly likely understand which line the warning came from in either case |
Bibo-Joshi
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
stacklevelparameter and details the warning message toset_new_attribute_deprecatedso users can pinpoint where the warning originates from.In response to https://t.me/pythontelegrambotgroup/491855