Merged
Conversation
Bibo-Joshi
requested changes
Aug 20, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a comment.
Apart from that, please have a look at the failing tests - the error messages should tell you what can be improved. If you can't see the error messages due to access stuff, please leave a comment.
Also, the tests need to be adapted. They are located at tests/test_jobqueue.py. If you're having troubles with the unit tests or if you're new to pytest, feel free to ask for help :)
Bibo-Joshi
requested changes
Aug 22, 2021
Bibo-Joshi
requested changes
Aug 25, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Also I noticed that the docstring should be updated to state the changes. Please use the .. versionchanged:: directive (see here for an example) and explain in 2-3 sentences that
- the
day_is_strictargument was removed - instead one can pass
-1to thedayparameter to make the job run on the last day of the month.
Also update the docstring of the day parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user-facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)Closes #2627