Check that {Inline, Reply}Keyboards are of the correct type#2657
Merged
Bibo-Joshi merged 6 commits intov14from Sep 15, 2021
Merged
Check that {Inline, Reply}Keyboards are of the correct type#2657Bibo-Joshi merged 6 commits intov14from
Bibo-Joshi merged 6 commits intov14from
Conversation
Resolved issues in telegram/replymarkup.py via DeepSource Autofix
Bibo-Joshi
reviewed
Sep 14, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
👍
can you call check_keyboard_type either at the end of __init__ for both or at the start of __init__ for both?
Bibo-Joshi
reviewed
Sep 15, 2021
Bibo-Joshi
pushed a commit
that referenced
this pull request
Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users don't input the keyboard in the correct format, i.e a list of lists, then the resulting error is hard to debug and its not obvious what went wrong.
inspired from #2652