Move error_handler error handing into Dispatcher.dispatch_error#2660
Merged
Bibo-Joshi merged 5 commits intov14from Sep 17, 2021
Merged
Move error_handler error handing into Dispatcher.dispatch_error#2660Bibo-Joshi merged 5 commits intov14from
Bibo-Joshi merged 5 commits intov14from
Conversation
2 tasks
3539dd8 to
504f9d0
Compare
harshil21
requested changes
Sep 16, 2021
Member
harshil21
left a comment
There was a problem hiding this comment.
only 2 nitpicks because the changes are good!
harshil21
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2601
replacement for #2649
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)