Add generic 'edited' update filter#2705
Conversation
Added a filter Filters.update.edited working for both messages and channel posts. Closes python-telegram-bot#2703
There was a problem hiding this comment.
Thanks for the quick PR! The new filter itself looks good :) However, we will need both documentation & tests for the new functionality (the PR template is there for a reason 😉 ). The documentation is just a few lines below your changes, you can add the new filter there. For the tests, please have a look at the file tests/test_filters.py and add a new test - you can copy & adapt the existing tests for Filters.update.*. The contribution guide also has a number of details on bulding the docs and running the tests ;)
Thank you for the feedback, im on it 😃 |
Added `Filters.update.edited` to tests and documentation.
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM 🙂 I'll ask for a second review from the dev team and then we can merge
|
Thank you for the contribution @PhilippFr ! |
Added a filter
Filters.update.editedworking for both messages and channel posts.Closes #2703