Fix from attribute#2719
Merged
Bibo-Joshi merged 12 commits intopython-telegram-bot:v14from Nov 21, 2021
SimonDamberg:fix-from-attribute
Merged
Fix from attribute#2719Bibo-Joshi merged 12 commits intopython-telegram-bot:v14from SimonDamberg:fix-from-attribute
Bibo-Joshi merged 12 commits intopython-telegram-bot:v14from
SimonDamberg:fix-from-attribute
Conversation
harshil21
requested changes
Oct 9, 2021
Member
harshil21
left a comment
There was a problem hiding this comment.
There's a pre-commit test failing. Can you add a pylint ignore on that line? see the other places in the code on how to add a pylint ignore.
Member
rather just do what pylint suggests to do ;) |
Contributor
Author
|
Addressed your comments 😄 |
Bibo-Joshi
reviewed
Oct 12, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a bit of nitpicking below :)
Member
|
@SimonDamberg are you still interested in finishing the PR? :) |
Contributor
Author
|
A lot of things came up at school and job. If someone wants to clean up and finish, feel free to do so :) |
# Conflicts: # tests/test_conversationhandler.py
harshil21
requested changes
Nov 21, 2021
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
harshil21
approved these changes
Nov 21, 2021
Member
|
Thanks for getting this started @SimonDamberg :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TelegramObject.__getitem__now raisesKeyErrorinstead of returningNone, and a special case is made forobj['from']to look upobj['from_user'].__getitem__override fromMessageKeyErrorinstead ofNone.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)