Make file paths in tests agnostic to execution source path #2701 by eldbud · Pull Request #2727 · python-telegram-bot/python-telegram-bot

eldbud · 2021-10-11T20:27:42Z

added PROJECT_ROOT_PATH and TEST_DATA_PATH constants in conftest
added data_file function in conftest
converted usages of files from the data folder to use the data_file function

resolves #2701

…ryptionError (python-telegram-bot#2621) * move telegramdecryptionerror to error.py * Change error class name

…t#2612) * feat: add docs about docs * fix: improve looks * fix: make link work * fix: this looks better * Improved markdown, updated link * Less justifying Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

* Fix incomplete type annotations for CallbackContext Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

* Feat: Custom pytest marker Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

* Make basepersistence methods abstractmethod Signed-off-by: starry69 <starry369126@outlook.com> Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

)

…am-bot#2619, python-telegram-bot#2636)

…m-bot#2634) Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

python-telegram-bot#2657)

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: poolitzer <25934244+Poolitzer@users.noreply.github.com>

# Conflicts: # telegram/bot.py # telegram/ext/callbackcontext.py # telegram/ext/dispatcher.py # telegram/ext/extbot.py # telegram/ext/jobqueue.py # tests/conftest.py # tests/test_bot.py

…ass_data_file fixture

…unction to conftest, replaced usages of paths with the above wherever possible

…n_source_path_#2701 # Conflicts: # tests/test_bot.py # tests/test_files.py # tests/test_warnings.py

eldbud · 2021-10-11T20:46:58Z

tried all the ways the instructions provide to link this pr to the issue - commit with keyword and issue number in message, and also in the description. doesn't link...

harshil21 · 2021-10-12T02:08:56Z

@eldbud Not your fault, it only works when the base branch is master apparently, we'll manually link and close it

Bibo-Joshi · 2021-10-12T06:48:25Z

Overall looks good - nice contribution! I take it that you actually tested running the tests from different working directories?
Can you please merge v14 into this branch? IISC there are some commits are not in your branch yet and e.g. #2724 added new files to the tests

eldbud · 2021-10-12T11:26:39Z

I take it that you actually tested running the tests from different working directories?

indeed :)

eldbud · 2021-10-12T12:05:43Z

I take it that you actually tested running the tests from different working directories?

indeed :)

i just rechecked my reply, and i see i do have a problem with test_webhook_ssl_just_for_telegram, when not running from project root. I'll attend to it later today.

eldbud · 2021-10-12T16:46:27Z

i just rechecked my reply, and i see i do have a problem with test_webhook_ssl_just_for_telegram, when not running from project root. I'll attend to it later today.

ok, fixed. pr is ready for merge unless there are any issues i need to attend to.

@Bibo-Joshi seems i have no authorization to request review ("reviewers" on the right side pane is empty, and clicking it does nothing)

Bibo-Joshi · 2021-10-13T06:12:58Z

Thanks for the nice contribution :)

Bibo-Joshi and others added 27 commits September 15, 2021 17:09

Temporarily enable tests for the v14 branch

331c4f5

Move and Rename TelegramDecryptionError to telegram.error.PassportDec…

9dc30cf

…ryptionError (python-telegram-bot#2621) * move telegramdecryptionerror to error.py * Change error class name

Improve Type Hinting for CallbackContext (python-telegram-bot#2587)

3a19383

* Fix incomplete type annotations for CallbackContext Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

Add Custom pytest Marker to Ease Development (python-telegram-bot#2628)

414a18c

* Feat: Custom pytest marker Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Make BasePersistence Methods Abstract (python-telegram-bot#2624)

8edb49d

* Make basepersistence methods abstractmethod Signed-off-by: starry69 <starry369126@outlook.com> Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

Refactor Initialization of Persistence Classes (python-telegram-bot#2604

cce9c18

)

Remove __dict__ from __slots__ and drop Python 3.6 (python-telegr…

dc0207a

…am-bot#2619, python-telegram-bot#2636)

Remove day_is_strict argument of JobQueue.run_monthly (python-telegra…

4af252f

…m-bot#2634) Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

Drop Non-CallbackContext API (python-telegram-bot#2617)

b6e4b54

Fix Signatures and Improve test_official (python-telegram-bot#2643)

4359812

Remove Deprecated Functionality (python-telegram-bot#2644)

dbdd35e

Add User Friendly Type Check For Init Of {Inline, Reply}KeyboardMarkup (

a7c7c82

python-telegram-bot#2657)

Refine Dispatcher.dispatch_error (python-telegram-bot#2660)

8ac65fc

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Warnings Overhaul (python-telegram-bot#2662)

66f0604

Clear Up Import Policy (python-telegram-bot#2671)

4f21c06

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Make InlineQuery.answer Raise ValueError (python-telegram-bot#2675)

5542a46

Doc Fixes (python-telegram-bot#2597)

2cf9311

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: poolitzer <25934244+Poolitzer@users.noreply.github.com>

Merge remote-tracking branch 'upstream/v14' into v14

bcc62bb

# Conflicts: # telegram/bot.py # telegram/ext/callbackcontext.py # telegram/ext/dispatcher.py # telegram/ext/extbot.py # telegram/ext/jobqueue.py # tests/conftest.py # tests/test_bot.py

Merge remote-tracking branch 'upstream/v14' into v14

9ed515a

create test_data_path fixture

53e9b0e

on it

a2b01a5

in the process of making tests use the newly created data_file and cl…

46b5a7c

…ass_data_file fixture

added PROJECT_ROOT_PATH and TEST_DATA_PATH constants, and data_file f…

0745488

…unction to conftest, replaced usages of paths with the above wherever possible

Merge remote-tracking branch 'upstream/v14' into v14

d82473a

Merge branch 'v14' into Make_file_paths_in_tests_agnostic_to_executio…

c581f27

…n_source_path_#2701 # Conflicts: # tests/test_bot.py # tests/test_files.py # tests/test_warnings.py

removed leftover print

dd0bead

eldbud changed the title ~~Make file paths in tests agnostic to execution source path #2701~~ Make file paths in tests agnostic to execution source path resolves #2701 Oct 11, 2021

eldbud changed the title ~~Make file paths in tests agnostic to execution source path resolves #2701~~ Make file paths in tests agnostic to execution source path #2701 Oct 11, 2021

closes python-telegram-bot#2701

fb41e1b

closes python-telegram-bot#2701

3193994

harshil21 added the ⚙️ tests affected functionality: tests label Oct 12, 2021

harshil21 added this to the v14 milestone Oct 12, 2021

Bibo-Joshi linked an issue Oct 12, 2021 that may be closed by this pull request

[FEATURE/DISCUSSION] Make file paths in tests agnostic to execution source path #2701

Closed

fixed test_updater failure, now tests pass from any working dir

870e9d3

Bibo-Joshi merged commit 1adc96c into python-telegram-bot:v14 Oct 13, 2021

github-actions bot locked and limited conversation to collaborators Oct 14, 2021

harshil21 added the hacktoberfest-accepted other: hacktoberfest-accepted label Oct 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make file paths in tests agnostic to execution source path #2701#2727

Make file paths in tests agnostic to execution source path #2701#2727
Bibo-Joshi merged 30 commits intopython-telegram-bot:v14from
eldbud:Make_file_paths_in_tests_agnostic_to_execution_source_path_#2701

eldbud commented Oct 11, 2021 •

edited

Loading

Uh oh!

eldbud commented Oct 11, 2021

Uh oh!

harshil21 commented Oct 12, 2021

Uh oh!

Bibo-Joshi commented Oct 12, 2021

Uh oh!

eldbud commented Oct 12, 2021

Uh oh!

eldbud commented Oct 12, 2021 •

edited

Loading

Uh oh!

eldbud commented Oct 12, 2021 •

edited

Loading

Uh oh!

Bibo-Joshi commented Oct 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

eldbud commented Oct 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eldbud commented Oct 11, 2021

Uh oh!

harshil21 commented Oct 12, 2021

Uh oh!

Bibo-Joshi commented Oct 12, 2021

Uh oh!

eldbud commented Oct 12, 2021

Uh oh!

eldbud commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eldbud commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bibo-Joshi commented Oct 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

eldbud commented Oct 11, 2021 •

edited

Loading

eldbud commented Oct 12, 2021 •

edited

Loading

eldbud commented Oct 12, 2021 •

edited

Loading