Asyncio by Bibo-Joshi · Pull Request #2731 · python-telegram-bot/python-telegram-bot

Bibo-Joshi · 2021-10-14T06:13:40Z

Supersedes #2402. Closes #2288 when ready - which is not in the forseable future :D

ext-tests are deleted for now so that we can first concentrate on getting telegram to work
any changes to v14 should be merged into this ASAP

TODO

Let's use this as place to write everything down that comes to mind while working on this - will be a lot

Details

move PtbRequestBase and HttpxRequest to a tg.request module/package. Maybe rename to RequestBase and HTTPXRequest
Improve handling of files in request - probably move that logic into a standalone method or even into Bot?
Update error code handling in request, use the enum from the std-lib
Check if we get coroutine was never awaited somewhere in the tests and also check if we can make those warnings fail the tests
check back with noam on whether the timeout parameter should be used for write_timeout as well in in BaseRequest
Check back with Noam about httpx connection pool limits: IISC on pool_timeout we want to create a new connection instead of dropping the request?!
Think about how we handle non-async callbacks for handlers and jobs. We might want to make sure that they run in a background thread - which is the default behavior of APscheduler

Think about what to do with exceptions in the long running tasks of updater. Currently we put them in the update_queue, which isn't really nice
persistence
think about a replacement for exception_event
a lot of tests
- For JobQueue test that weekdays are working as expected to avoid regression when we update APS - see here and here
check for added # TODO comments
update examples. for chatmemberbot.py we can also include the changes proposed here

Things that don't need to be done in this PR

If they are not, create issues for them!

set socketops
switch to a different library for webhooks - maybe starlette (backend of fastAPI)?
Add transaction support to BaspePersistence, i.e. abstract methods start/end_transaction so that we can do

tell persistence that we're going to start transaction
hand over data
tell persistence that I'm finished

Review

Thinks to look out for in a review

double check if we need to update docs regarding accepted types
Check for unwanted changes (also in tests!) - these are likely to be there because merging v14 was a mess
- Some test_slots_behavior tests went missing for some reason. check the diff and re-add them
Add .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings
Also manually check whether thumbs are properly handled everywhere(!) where you can pass a thumb
take all the examples up for a test run
manually test webhook setups - this PR changes if the webserver listens to https://… or http://…
manually test how kill pid works when using App.run_* & starting the script as a background task

???

I wrote this down while working on a signal-handler based exit. not sure, if still relevant

On windows, quick-exit by task.cancel() leads to the issue discribed in https://bugs.python.org/issue39232. Can be resolved by using loop.run_until_complete() instead of asycnio.run(). think about if we want to address this somehow (documentation/helper function/adapting the internals or mechanichs or updater)
asyncio.run in combination with webhooks leads to asyncio.run() causes RuntimeError because of loop.close() tornadoweb/tornado#3092 - check if we can do something smart about that

github-actions

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

github-actions

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

examples/contexttypesbot.py

# Conflicts: # telegram/_files/file.py # telegram/ext/_basepersistence.py # telegram/ext/_builders.py # telegram/ext/_callbackqueryhandler.py # telegram/ext/_chatjoinrequesthandler.py # telegram/ext/_chatmemberhandler.py # telegram/ext/_choseninlineresulthandler.py # telegram/ext/_commandhandler.py # telegram/ext/_dispatcher.py # telegram/ext/_handler.py # telegram/ext/_inlinequeryhandler.py # telegram/ext/_messagehandler.py # telegram/ext/_picklepersistence.py # telegram/ext/_pollanswerhandler.py # telegram/ext/_pollhandler.py # telegram/ext/_precheckoutqueryhandler.py # telegram/ext/_shippingqueryhandler.py # telegram/ext/_stringcommandhandler.py # telegram/ext/_stringregexhandler.py # telegram/ext/_typehandler.py # telegram/ext/_updater.py # telegram/request.py

tests/test_application.py

harshil21

uploading files rework review.

Btw codecov shows that quite a few lines in Application and ConversationHandler are not covered in tests?

telegram/_files/inputfile.py

telegram/_bot.py

telegram/request/_requestparameter.py

Bibo-Joshi added enhancement 🛠 breaking change type: breaking labels Oct 14, 2021

Bibo-Joshi added this to the v14 milestone Oct 14, 2021

github-actions bot reviewed Oct 14, 2021

View reviewed changes

Bibo-Joshi mentioned this pull request Oct 25, 2021

add **connection_pool_kw to Request() constructor #2560

Closed

4 tasks

Bibo-Joshi added the 🛠 refactor change type: refactor label Nov 2, 2021

Bibo-Joshi force-pushed the v14 branch from 3e8d1fa to 8b5966d Compare November 19, 2021 18:47

Bibo-Joshi force-pushed the asyncio branch from 7543e3f to bef5d38 Compare November 20, 2021 10:01

harshil21 force-pushed the v14 branch from abc75b1 to 0af4def Compare November 20, 2021 16:38

Bibo-Joshi force-pushed the v14 branch 3 times, most recently from 5c26c91 to 74c4270 Compare December 13, 2021 18:14

Bibo-Joshi force-pushed the asyncio branch from da08480 to 8dccc80 Compare December 13, 2021 20:17

Poolitzer force-pushed the v14 branch from 74c4270 to 65f3599 Compare December 18, 2021 09:52

Bibo-Joshi force-pushed the asyncio branch from eb44c49 to 074756b Compare December 18, 2021 11:31

Bibo-Joshi force-pushed the v14 branch from 7b9cd7e to d66297e Compare January 3, 2022 11:42

Bibo-Joshi force-pushed the asyncio branch from e1b66bd to e1430f5 Compare January 3, 2022 12:26

harshil21 reviewed Jan 20, 2022

View reviewed changes

examples/contexttypesbot.py Outdated Show resolved Hide resolved

Bibo-Joshi force-pushed the v14 branch from 3b1a142 to d8e3fb4 Compare February 6, 2022 09:29

Single, squashed commit

f52a96d

Bibo-Joshi force-pushed the asyncio branch from 9833302 to f52a96d Compare February 6, 2022 11:52

Get CH to roughly work

ea70388

Bibo-Joshi changed the title ~~Not even WIP: Asyncio~~ WIP: Asyncio Feb 8, 2022

Bibo-Joshi added 5 commits February 9, 2022 17:40

Start fixing some sphinx warnings

362e7b2

More reference fixes

ecd909d

Try fixing wrong source links on RTD

d0565fc

Slowly get started on request tests

985d24f

Bibo-Joshi and others added 13 commits April 17, 2022 20:58

shutdown with signal handlers

70ee0ff

try improving tests

54c83dc

try again

b8f41a5

One last try

0a83834

fix some docs of HTTPXRequest

193c435

move definition of InitAppBuilder type alias to bottom of file

079fca1

try to make codacy happy w.r.t hardcoded token in example

a1bf431

add a debug print to failing test

74bf2df

try fixing the failing test

bd8fe9e

create_task while not running: warn instead of log

a7a11bc

second try for failing test

9a541f0

tiny doc fix

c7677c2

Another small doc fix

b4fa728

harshil21 reviewed Apr 20, 2022

View reviewed changes

tests/test_application.py Show resolved Hide resolved

harshil21 and others added 6 commits April 20, 2022 22:24

jobqueue doc fixes

12f1322

Rework uploading files - tests for RequestData are not yet adjusted

bafe934

Merge remote-tracking branch 'origin/asyncio' into asyncio

f36aafb

doc adjustments

0086ad5

Test RequestData

1aa2fc1

document a limit about send_document/voice

f1f7e24

harshil21 reviewed Apr 22, 2022

View reviewed changes

Poolitzer and others added 4 commits April 23, 2022 10:14

Fix: Small doc fixes + improvements

88b8e19

forgot to commit review

58c7781

fix pre-commit

66d9a13

finally fix certificate passing

9389bc9

Bibo-Joshi merged commit ad5a1fb into v14 Apr 24, 2022

Bibo-Joshi deleted the asyncio branch April 24, 2022 11:19

github-actions bot locked and limited conversation to collaborators May 1, 2022

Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asyncio#2731

Asyncio#2731
Bibo-Joshi merged 171 commits intov14from
asyncio

Bibo-Joshi commented Oct 14, 2021 •

edited by harshil21

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Uh oh!

harshil21 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Bibo-Joshi commented Oct 14, 2021 • edited by harshil21 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Things that don't need to be done in this PR

Review

???

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Bibo-Joshi commented Oct 14, 2021 •

edited by harshil21

Loading