Conversation
Member
|
Interesting that it failed for you locally while it passed the CI. Could you specify the error messages that you got? |
Bibo-Joshi
approved these changes
Oct 28, 2021
Poolitzer
approved these changes
Oct 29, 2021
Member
Poolitzer
left a comment
There was a problem hiding this comment.
Wasn't failing for me, but these changes look fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylint and mypy were failing for me locally after #2646, so I updated the related files a bit. All of my local mypy failures are from the
filtersmodule, which I guess will be refactored in #2178 so didn't change that.