Conversation
also added a link to the _per* FAQ page
also improved one warning message and removed a break
Bibo-Joshi
requested changes
Oct 30, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR :) I've left a couple of nitpicks. In addition to that, could you add an item to the PR template about adding new handlers to these checks?
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
also added a checkmark to the PR template
Bibo-Joshi
requested changes
Nov 3, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates :) just a bit more nitpicking …
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Bibo-Joshi
approved these changes
Nov 5, 2021
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
nice addition 👍 if @harshil21 gives a LGTM as well, we can merge :)
harshil21
reviewed
Nov 6, 2021
also added test for the nested conv warn
Member
|
Tests failing due to API changes. Merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)This PR closes #2615.
I did make a decision while implementing this: I don't think it makes sense to break the for loops after one warning. The warnings menu will not show more then one unique warning anyway, and we swallow non unique ones this way or unique ones if the user changes their
filterwarningmethod.