Invite link convenience functionality#2782
Conversation
d4cf543 to
3164c0b
Compare
harshil21
left a comment
There was a problem hiding this comment.
nice feature, but is there a reason why we don't use the other parameters of ChatInviteLink here too? Similar to how we do in send/edit_location
TBH, I hadn't really thought about it, but interesting idea! you'd do something like e.g. if isinstance(invite_link, ChatInviteLink):
expire_date = expire_date or invite_link.expire_date? That could work. If we want to allow users to e.g. delete the def edit_chat_link(…, expire_date = DEFAULT_NONE):
if isinstance(invite_link, ChatInviteLink):
expire_date = expire_date or invite_link.expire_date
expire_data = DefaultValue.get_value(expire_date)such that At first glance, I'm not sure if the added convenience is worth the added complexity of the method. What do you think? |
|
ugh, in that case probably best to leave it like this. Not to mention documentation will also increase in complexity. |
adds nome convenience functionality around chat invite links. nothing urgent.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)