Skip to content

API 5.6#2835

Merged
Bibo-Joshi merged 8 commits intomasterfrom
api-5.6
Jan 3, 2022
Merged

API 5.6#2835
Bibo-Joshi merged 8 commits intomasterfrom
api-5.6

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Dec 31, 2021 •
edited
Loading

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs

  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Dec 31, 2021
@harshil21 harshil21 added this to the 13.10 milestone Dec 31, 2021
@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Dec 31, 2021
Bibo-Joshi
Bibo-Joshi reviewed Dec 31, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR!

  • which fixture did you fix ragarding message entities?
  • I guess test_bot is yet to be adapted? :D

@harshil21
Copy link
Member Author

harshil21 commented Dec 31, 2021

Thanks for the quick PR!

Thanks for the quick review!

  • which fixture did you fix ragarding message entities?

See tests/test_messageentity.py. There was a spelling error.

  • I guess test_bot is yet to be adapted? :D

I'm not sure what more to change in it, i'll see

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Dec 31, 2021

  • which fixture did you fix ragarding message entities?

See tests/test_messageentity.py. There was a spelling error.

ah, you mean type -> type_? yeah, that's good

  • I guess test_bot is yet to be adapted? :D

I'm not sure what more to change in it, i'll see

well, currently codecov complains about all the if protected_content: not being covered. While the coverage report will be more friendly when moving that clause into self._message (because then it's fewer of those), we should actually test it - should be doable by checking Message.has_protected_content on the return value in most cases.

@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Dec 31, 2021
github-actions[bot]
github-actions bot reviewed Dec 31, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Bibo-Joshi
Bibo-Joshi reviewed Jan 1, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Apart from nitpicking, I guess it's ready, though I'd like for @Poolitzer to have a look as well.

just double checking: are you both comfortable with postponing Defaults.protect_content to v14? If you prefer to include it directly, we can do that.

Poolitzer
Poolitzer approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Im comfortable with postponing Defaults, jup.

@harshil21 harshil21 added the 📋 pending-merge work status: pending-merge label Jan 2, 2022
@Bibo-Joshi Bibo-Joshi merged commit 98bf378 into master Jan 3, 2022
@Bibo-Joshi Bibo-Joshi deleted the api-5.6 branch January 3, 2022 07:13
@harshil21 harshil21 removed the 📋 pending-merge work status: pending-merge label Jan 3, 2022
@ghost
Copy link

ghost commented Jan 3, 2022

pain in the ass -_-

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Jan 3, 2022

what?

@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Milestone

13.10

Development

Successfully merging this pull request may close these issues.

3 participants

@harshil21 @Bibo-Joshi @Poolitzer