Merged
Conversation
Bibo-Joshi
requested changes
Jan 4, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! left some comments. regarding api_defaults:
It's public, because we access it outside of Defaults in Bot. And it doesn't provide any info that's not available otherwise - you can just check the properties of Defaults. In fact, even the properties are of no actual value for a user …
IMO it's not necessary to make it private and then having to shut up pylint about access to private attributes.
If you prefer, we can even just give it a docstring.
23f75f0 to
f81ea04
Compare
Bibo-Joshi
approved these changes
Jan 5, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM! @Poolitzer are you interested in reviewing?
the deepsource failures are unrelated and almost all false positives - let's ignore them on this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)Any more changes to be done?
Closes #2839