Merged
Conversation
Bibo-Joshi
requested changes
Feb 1, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the fast PR! Left a few nitpicks.
One can download the thumb of a sticker set - maybe that suffices for the _3 test?
import asyncio
from telegram import Bot
async def main():
async with Bot(TOKEN') as bot:
sticker_set = await bot.get_sticker_set('Potato')
await (await sticker_set.thumb.get_file()).download('video_thumb.webm')
if __name__ == '__main__':
asyncio.run(main())
Bibo-Joshi
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSIONtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.MessageUsed the
potato dogewebm sticker from: https://t.me/TrendingStickers/1978Note about a sticker test:
Didn't implement a
test_bot_methods_3_webmsince the webm file is too large to be a thumb... can anyone compress it?Edit:
Skipped that test, see that test for the reason.