Conversation
Bibo-Joshi
approved these changes
Apr 28, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
fine with me - merge at will :)
harshil21
approved these changes
Apr 29, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
nice. I also only see improvements
Bibo-Joshi
pushed a commit
that referenced
this pull request
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing the rewrite of my action today, I stumbled upon a new way to give permissions to action tokens. We had the issue that people who don't have write access to our repo (so those who came from forks) didn't generate tokens with write access to the pull request. This resulted in my action failing with the
Resource not accessible by integrationerror, see Poolitzer/pull/2 or the actual errror https://github.com/Poolitzer/python-telegram-bot/runs/6211635584?check_suite_focus=true or https://github.com/python-telegram-bot/python-telegram-bot/runs/6189881374?check_suite_focus=true.This was unfixable without exposing a token to the public. But with this new setting, we are all good \o/. See Poolitzer#3.
I see no downside to this change.