Merged
Conversation
Member
|
Hey Jason, thanks for your pull request! Testing sendAudio - File
You can try something like: |
Member
|
Great idea about decorators! |
Contributor
Author
|
Your method seems to be much better, i will try. I didn't imagine problem like that. T^T Thanks for your test and review! |
Member
|
All tests passed right away! Yay. I'm merging your pull request. Thank you very much! :) |
jeffffc
pushed a commit
to jeffffc/python-telegram-bot
that referenced
this pull request
May 9, 2018
Add Message.link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git is so hard for me. I add '.gitignore' and '.idea/' to .gitignore but it doesn't work, so i delete it directly orz.
I found that most [send*() functions] like sendVideo(), sendsticker() ... are similar, can we simplify them by decorator ?