Renamed job.context to job.data#3028
Merged
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom May 12, 2022
clot27:rename-job-context
Merged
Renamed job.context to job.data#3028Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom clot27:rename-job-context
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom
clot27:rename-job-context
Conversation
harshil21
requested changes
May 12, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
Thanks for the PR! There are some failing tests, which are related to this PR, where more references to context need to be updated like here
You can run the test suite by typing pytest -v in the root folder to see if there are some more missed changes.
Bibo-Joshi
approved these changes
May 12, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Nice work, thanks! LGTM. If @harshil21 approves as well, we can merge :)
harshil21
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first time contribution to the lib. Do let me know if I did something wrong or missed out something:D
closes #3015