Merged
Conversation
harshil21
reviewed
May 14, 2022
harshil21
reviewed
May 14, 2022
harshil21
approved these changes
May 14, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
Nice. Now we can use this in examples to enforce the correct version.
Member
Author
|
preview of the updated docs: |
Member
Author
|
@Poolitzer are you okay with the renaming |
Member
|
@Bibo-Joshi Havent looked into the specifics of the implementation but I like the idea jup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renaming of
tg.bot_api_versiontotg.__bot_api_version__is just a suggestion so far. Apparently in the first discussion to add this variable we decided against that. I have changed my view on that, but that doesn't necessarily mean that we have to do the renaming :)__version__,__version_info__and bot api versionVersion