Conversation
Poolitzer
approved these changes
May 18, 2022
Comment on lines
+75
to
+77
| Warning: | ||
| When setting :paramref:`block` to :obj:`False`, you cannot rely on adding custom | ||
| attributes to :class:`telegram.ext.CallbackContext`. See its docs for more info. |
Member
There was a problem hiding this comment.
hm, what is this warning doing here? Is it saying that the custom .args attribute which this handler adds wont be there?
Member
Author
There was a problem hiding this comment.
When you have handlers in multiple groups and you do context.custom_arg = foo in a lower group, you cannot rely on context.custom_arg being available in the higher group. We have this warning in all handlers.
harshil21
requested changes
May 18, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
tests should be updated + .rst file renaming needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2885. supersedes & closes #2890
in hindsight the review process of #2890 revealed to me that it might be better to
update_commands()etc. IMOChecklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)