Merged
Conversation
24 tasks
harshil21
reviewed
May 25, 2022
harshil21
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2741 (comment) and the respective item of #2633.
I also made some smaller code changes, hence this is a standalone PR instead of being included in the doc fixes pr.
In addition to updating the docs of
Message, I also made corresponding changes toPollandGame. Note that there are also classes likeInlineQueryResult*which have acaption_entitiesattribute. However, those classes are used as input for API methods and having those attributes always be list would make problems - we'd have to somehow decide when to pass an empty list to TG and when to skip the parameter. So I left them as is.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__s