Merged
Conversation
# Conflicts: # .github/workflows/pre-commit_dependencies_notifier.yml
Member
Author
|
I'll have to try & check how I can get the tests to work on unix. otherwise, this ready for a first round of review imo |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
got tests to work on ubuntu. Skipped them on macOS, b/c I don't think that it's really worth the effort 😬 |
|
@Bibo-Joshi @harshil21 I created an asyncio limiter that doesn't have the httpx issue. In fact, the issue doesn't have anything to do with httpx at all. The interface is similar although a tad different, but it is considerably more efficient. You're welcome to test it and tell me if it's better for you :-) |
harshil21
requested changes
Aug 4, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
Finally we have a working rate limiter! Didn't test out the changes locally yet. Also have a gut feeling that there's probably a bug here and there which I didn't catch
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
# Conflicts: # telegram/_bot.py
Bibo-Joshi
commented
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3018
Some comments:
aiolimiterlibrary despite New Mechanism for Avoiding Flood Limits #3018 (comment). AFAIK the performance problems are only relevant for very high load and the built-in implementation is only supposed to be a minimal effort reference implementation …aiolimiteras optional requirement, since using theAIORateLimiteris purely opt-in. This design goes in the direction that I'd like to discuss in the context of https://github.com/python-telegram-bot/python-telegram-bot/projects/7#card-77767364rate_imit_argsto shortcut methods. IMO that would add too much of a connection between tg and tg.ext and if users want to passrate_limit_argsthey can always use the standard methods instead.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__s