unify args and attributes docstrings in Message class#3217
Merged
harshil21 merged 5 commits intopython-telegram-bot:doc-fixesfrom Sep 1, 2022
Merged
unify args and attributes docstrings in Message class#3217harshil21 merged 5 commits intopython-telegram-bot:doc-fixesfrom
harshil21 merged 5 commits intopython-telegram-bot:doc-fixesfrom
Conversation
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Contributor
Author
|
The first patch further unified the docstrings upon the suggestions, and cleared white-spaces. |
harshil21
approved these changes
Aug 30, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
Nice work! Thank you! Deepsource failures are unrelated to this PR. Let's wait a bit longer in case other devs want to review
Member
|
Harshil is the authorothy on docstrings IMO :D so I'm good. codacy is just a setting thing, we can ignore that. @harshil21 IMO you can merge at will :) |
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
2 more extra spaces are found upon suggestions.
Contributor
Author
|
The second patch also removes extra spaces in other 2 places. Hopefully, these should be all. |
Member
|
Thanks for the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #3109,
Listargs docstrings and attributes docstrings are unified, and the lines are limited to their maximum length.Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__s