Add chat_id(s) and username(s) parameters to ChatJoinRequestHandler #3261
Merged
Bibo-Joshi merged 10 commits intopython-telegram-bot:masterfrom Oct 2, 2022
Merged
Add chat_id(s) and username(s) parameters to ChatJoinRequestHandler #3261Bibo-Joshi merged 10 commits intopython-telegram-bot:masterfrom
Bibo-Joshi merged 10 commits intopython-telegram-bot:masterfrom
Conversation
Poolitzer
requested changes
Sep 28, 2022
Member
Poolitzer
left a comment
There was a problem hiding this comment.
Thanks for the PR, good job implementing the tests.
d96596d to
9a4eb95
Compare
`chat_id` and `username` parameters should allow filtering requests to allow only those from a specified chat ID or username.
9a4eb95 to
0123635
Compare
Contributor
Author
|
The CI failure is not related to code changes. |
Poolitzer
requested changes
Sep 28, 2022
Bibo-Joshi
requested changes
Sep 28, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hi, thanks also from my side for the PR!
Bibo-Joshi
approved these changes
Sep 30, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Except the suggested reformulation, this LGTM :)
harshil21
approved these changes
Sep 30, 2022
Poolitzer
requested changes
Oct 2, 2022
Member
Poolitzer
left a comment
There was a problem hiding this comment.
One last comment, code is good!
Member
|
Thank you for your contribution @miles170 and thanks also for your patience during the review process :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chat_idandusernameparameters should allow filtering requests to allow only those from a specified chat ID or username.Closes #3215.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__s