Merged
Conversation
Also make py3.11 tests as non-experimental
Bibo-Joshi
reviewed
Oct 7, 2022
Bibo-Joshi
requested changes
Oct 17, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Sorry for getting back to this late.
The speedup in the CI doesn't seem as big as for you locally, but it's nice nonetheless. Tests seem to run rather stable, too, so let's add it :) Can you also add a note to the contrib guide that tells users how they can use pytest-xdist? Probably also add a warning that this may effect the test results in rare edge cases :D
Bibo-Joshi
approved these changes
Oct 19, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM 👍 if there's nothing left from your side, I can merge once the tests pass :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the test suite in parallel by using the
pytest-xdistplugin. In my case, the test suite went from taking ~14 mins to complete to just 3m 28s!That's roughly a 75% improvement!