Add mention_XXX to Chat class#3308
Merged
Bibo-Joshi merged 6 commits intopython-telegram-bot:masterfrom Oct 31, 2022
Merged
Conversation
Poolitzer
requested changes
Oct 26, 2022
Member
Poolitzer
left a comment
There was a problem hiding this comment.
Hey there, quick and well made PR, did not spot a logic fault! Just nitpicking at words, as I usually do.
harshil21
reviewed
Oct 26, 2022
Member
harshil21
left a comment
There was a problem hiding this comment.
Nice and swift work. I think we should also add a Raises: block to each of the methods describing when the method fails
harshil21
approved these changes
Oct 30, 2022
Member
|
Thank you very much for your contribution @miles170 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
mention_markdownandmention_markdown_v2andmention_htmlto Chat class.Closes #3216.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__s