update: added deep link maximum character constant#3315
Merged
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom Nov 1, 2022
Merged
update: added deep link maximum character constant#3315Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfrom
Conversation
Member
|
Hi. You added the constant above the line where it says that "the constants above this line are tested", while not adding a test. I don't think this variable needs one (and it wouldn't be fun to write either), so just move it down. |
Member
|
Thank you for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Telegram API doc, the parameter can only be up to 64 characters long.
Checklist