Skip to content

refactor: add enum constants#3336

Closed
lemontree210 wants to merge 8 commits intopython-telegram-bot:masterfrom
lemontree210:enums-instead-of-literals-3107
Closed

refactor: add enum constants#3336
lemontree210 wants to merge 8 commits intopython-telegram-bot:masterfrom
lemontree210:enums-instead-of-literals-3107

Conversation

@lemontree210
Copy link
Member

@lemontree210 lemontree210 commented Nov 5, 2022 •
edited
Loading

addresses #3107

@lemontree210
refactor(Bot) add enum constants for Bot.set_webhook()
51023c9 
* add constants for `max_connections`

* expand docstring for `secret_token`
@lemontree210 lemontree210 changed the title refactor(Bot) add enum constants for Bot.set_webhook() refactor(Bot) add enum constants Nov 5, 2022
@lemontree210 lemontree210 changed the title refactor(Bot) add enum constants refactor: add enum constants Nov 5, 2022
@harshil21 harshil21 added the ⚙️ documentation affected functionality: documentation label Nov 5, 2022
@lemontree210
refactor/fix(Bot) add enum constants to LocationLimit, fix docstrings
2014f32 
* add limits for heading

* add minimum proximity_alert_radius
(as it is non-zero)

* fix docstrings that link to HEADING
constant twice instead of PROXIMITY_ALERT_RADIUS
(and hence 360 was displayed instead of 100000)
harshil21
harshil21 reviewed Nov 5, 2022
View reviewed changes
@lemontree210
Copy link
Member Author

lemontree210 commented Nov 5, 2022

Question regarding limits for Location and send_location: I know that in Telegram API itself most limits are only listed in sendLocation and not in Location, e.g. live_period and heading.

Should I list all the limits in Location as well or do I stick to what's listed or not listed in Telegram API?

@harshil21
Copy link
Member

harshil21 commented Nov 5, 2022

Should I list all the limits in Location as well or do I stick to what's listed or not listed in Telegram API?

I think we should stick to TG API docs.

@Poolitzer Poolitzer mentioned this pull request Nov 6, 2022
Merged
Bibo-Joshi
Bibo-Joshi reviewed Nov 6, 2022
View reviewed changes
@lemontree210 lemontree210 mentioned this pull request Nov 8, 2022
Merged
8 tasks
lemontree210 added a commit that referenced this pull request Nov 8, 2022
@lemontree210
refactor: NumberOfUpdatesLimit -> PollingLimit
fcf6e57 
as suggested in review for PR #3336,
but in singular (rather than `...Limits`)
to conform with review for #3343
@lemontree210
Copy link
Member Author

lemontree210 commented Nov 8, 2022

closing this PR, all work moved to #3351 (with branches within same repo as opposed to fork)

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

@harshil21 harshil21 harshil21 left review comments

Assignees

No one assigned

Labels

⚙️ documentation affected functionality: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lemontree210 @harshil21 @Bibo-Joshi