Supercharge TelegramObject.to_dict#3353
Merged
Bibo-Joshi merged 4 commits intomasterfrom Nov 13, 2022
Merged
Conversation
Bibo-Joshi
requested changes
Nov 9, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Nice, and it's not even fridy 🥳 Could you also extend the to_dict tests to make sure that the recursive setting now properly extends to the (nested) lists?
Member
Author
This is already tested in the classes which have those, e.g. |
Bibo-Joshi
approved these changes
Nov 11, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
DS failure is unrelated. When the tests pass, this LGTM :)
harshil21
commented
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the logic of
TO.to_dictin subclasses toTelegramObjectitself, which was mainly dealing with sequences and converting datetimes to timestamps.Checklist for PRs
Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added new classes & modules to the docs and all suitable__all__s