New classes for API 6.3: `ForumTopic`, `ForumTopicCreated`, `ForumTopicClosed`, `ForumTopicReopened` by lemontree210 · Pull Request #3356 · python-telegram-bot/python-telegram-bot

lemontree210 · 2022-11-11T14:25:13Z

addresses #3340

lemontree210 · 2022-11-11T14:41:09Z

Actually, again, maybe the tests are worth adding when the methods are there, so it might make sense to review this as it is, then hopefully merge, and then we'll add tests with real methods.

…Created` + change docstring for the module will add tests for `ForumTopic` later on

telegram/_forumtopic.py

docs/source/telegram.rst

telegram/_forumtopic.py

telegram/_message.py

tests/test_forum.py

telegram/_forumtopic.py

`TelegramObject`'s `de_json()` will work fine if `None` is passed instead of empty dict

2 tests copied/pasted from another branch still fail

…_for_api_6.3

lemontree210 · 2022-11-14T10:24:11Z

This seems ready to be merged if there are no other comments.

harshil21

Now that all 7 forum methods have been implemented upstream, test_forum.py should be updated to test that.

Also we can add filters for the new status messages (ForumTopicCreated, etc). See filters.StatusUpdate as examples on how to add them, it's fairly straightforward.

tests/test_forum.py

# Conflicts: # docs/source/telegram.rst # telegram/_message.py

…_for_api_6.3

* `icon_color` and `icon_custom_emoji_id` must be optional * remove link to `Message.create_forum_topic` from docstring (there will be no such shortcut)

lemontree210 · 2022-11-17T08:38:04Z

I'm having trouble adding a test for ForumTopicCreated. My idea is that I should create a topic, then get updates, check the last Message and make sure it contains a service message in forum_topic_created attribute with the correct topic name. Somehow it doesn't work though, which maybe depends on how bot fixture works. (I do get service messages, but old ones.)

I tried to see how it was done for other classes representing service messages, but tests for classes like VideoChatScheduled, MessageAutoDeleteTimerChanged and others only seem to test slots, equality etc., but not the fact of the service message actually being issued. So I'm struggling to find any relevant examples to follow here :)

return 'ForumTopic', not bool

…_for_api_6.3

tests/test_forum.py

…w_classes_for_api_6.3

lemontree210 added 4 commits November 11, 2022 11:20

copy-paste Poolitzer's test_forum.py, move test from test_bot.py

374563d

refactor(test_forum.py): add fixture to create and delete topic

b5211d8

merge api_6.3_update

c24efa2

create classes ForumTopic, ForumTopic..., 1st test

726b6ab

lemontree210 marked this pull request as ready for review November 11, 2022 14:41

lemontree210 marked this pull request as draft November 11, 2022 14:46

harshil21 added this to the v20.0a5 milestone Nov 11, 2022

harshil21 added the ⚙️ bot-api affected functionality: bot-api label Nov 11, 2022

add tests for service message classes, fix de_json() in `ForumTopic…

7d77ae9

…Created` + change docstring for the module will add tests for `ForumTopic` later on

lemontree210 commented Nov 12, 2022

View reviewed changes

telegram/_forumtopic.py Outdated Show resolved Hide resolved

lemontree210 added 2 commits November 12, 2022 14:39

minor: remove TODO after comment in review

5c0a2e8

add tests and de_json() for ForumTopic

deaacfb

lemontree210 commented Nov 12, 2022

View reviewed changes

telegram/_forumtopic.py Outdated Show resolved Hide resolved

telegram/_forumtopic.py Outdated Show resolved Hide resolved

lemontree210 marked this pull request as ready for review November 12, 2022 12:04

harshil21 reviewed Nov 12, 2022

View reviewed changes

lemontree210 added 8 commits November 13, 2022 13:44

fix(typos in message.py): TopicForum -> ForumTopic

b627a9c

fix(_forumtopic.py): rm de_json(), replace {} with None in test

5fe81c1

`TelegramObject`'s `de_json()` will work fine if `None` is passed instead of empty dict

fix(telegram.rst): reorder alphabetically

d40e8a0

fix(message.py): add "forum_topic_closed", "_reopened" to de_json()

417bd26

fix(class docstrings) , optional): -> ): Optional. in attrs section

e12a8ff

refactor(test_forum.py) add/change fixtures

7328f43

2 tests copied/pasted from another branch still fail

fix(ForumTopic): make __eq__ check all required args (+icon_color)

99095c4

Merge remote-tracking branch 'origin/api_6.3_update' into new_classes…

1be6f67

…_for_api_6.3

harshil21 requested changes Nov 14, 2022

View reviewed changes

tests/test_forum.py Outdated Show resolved Hide resolved

tests/test_forum.py Outdated Show resolved Hide resolved

tests/test_forum.py Outdated Show resolved Hide resolved

Bibo-Joshi and others added 4 commits November 15, 2022 09:14

Merge branch 'api_6.3_update' into new_classes_for_api_6.3

0d3d1c0

# Conflicts: # docs/source/telegram.rst # telegram/_message.py

re-add new classes to toctree

46d24bc

Merge remote-tracking branch 'origin/api_6.3_update' into new_classes…

f51caf3

…_for_api_6.3

fix(Bot.create_forum_topic): return ForumTopic; change test fixture

f958cbc

lemontree210 added 4 commits November 16, 2022 14:51

fix(Bot.create_forum_topic): make 2 attrs optional, tweak docstring

759816f

* `icon_color` and `icon_custom_emoji_id` must be optional * remove link to `Message.create_forum_topic` from docstring (there will be no such shortcut)

fix existing test that was failing

d323c7f

add tests for Bot.create_forum_topic()

1b52d1c

rename fixture, replace dummy emoji ID with real one from fixture

011fcfa

lemontree210 added 6 commits November 17, 2022 18:50

remove failing test: service message can't be checked

61eca9a

remove 2 TODOs

748ca5f

fix signature of ExtBot.create_forum_topic()

ab33cb5

return 'ForumTopic', not bool

Merge remote-tracking branch 'origin/api_6.3_update' into new_classes…

c180f8f

…_for_api_6.3

add test for Bot.close_forum_topic() and .reopen_forum_topic()

27db94d

add (failing, commented) test for Bot.unpin_all_forum_topic_messages

b137494

Bibo-Joshi reviewed Nov 18, 2022

View reviewed changes

tests/test_forum.py Outdated Show resolved Hide resolved

harshil21 and others added 4 commits November 18, 2022 19:51

fix failing unpin_all_forum_messages test

3b12a8e

remove duplicate test from test_bot.py

620c0c2

status update filters

c2705e9

Merge remote-tracking branch 'origin/new_classes_for_api_6.3' into ne…

07a0967

…w_classes_for_api_6.3

harshil21 approved these changes Nov 18, 2022

View reviewed changes

Bibo-Joshi merged commit 0cc1d03 into api_6.3_update Nov 18, 2022

Bibo-Joshi deleted the new_classes_for_api_6.3 branch November 18, 2022 15:57

github-actions bot locked and limited conversation to collaborators Nov 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New classes for API 6.3: `ForumTopic`, `ForumTopicCreated`, `ForumTopicClosed`, `ForumTopicReopened`#3356

New classes for API 6.3: `ForumTopic`, `ForumTopicCreated`, `ForumTopicClosed`, `ForumTopicReopened`#3356
Bibo-Joshi merged 33 commits intoapi_6.3_updatefrom
new_classes_for_api_6.3

lemontree210 commented Nov 11, 2022 •

edited by Bibo-Joshi

Loading

Uh oh!

lemontree210 commented Nov 11, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemontree210 commented Nov 14, 2022

Uh oh!

harshil21 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemontree210 commented Nov 17, 2022 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lemontree210 commented Nov 11, 2022 • edited by Bibo-Joshi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lemontree210 commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemontree210 commented Nov 14, 2022

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemontree210 commented Nov 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lemontree210 commented Nov 11, 2022 •

edited by Bibo-Joshi

Loading

lemontree210 commented Nov 11, 2022 •

edited

Loading

lemontree210 commented Nov 17, 2022 •

edited

Loading