Don't throw error in BP.set_bot if store_cdc=True but bot.cdc is None#3384
Merged
Bibo-Joshi merged 3 commits intomasterfrom Nov 24, 2022
Merged
Don't throw error in BP.set_bot if store_cdc=True but bot.cdc is None#3384Bibo-Joshi merged 3 commits intomasterfrom
BP.set_bot if store_cdc=True but bot.cdc is None#3384Bibo-Joshi merged 3 commits intomasterfrom
Conversation
BP.set_bot if store_cdc=True bot bot.cdc is NoneBP.set_bot if store_cdc=True but bot.cdc is None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes some behavior introduced in #3266 .
Issue was reported at https://t.me/pythontelegrambotgroup/639987.
This change allows
ExtBot.callback_data_cacheto beNoneeven ifstore_arbitrary_callback_data is True. Reasoning:store_arbitrary_callback_datasuch that integrating persistence is as easy as possibleSo instead of reasing an error, this PR changes the behavior such that
Application.update_persistencejust doesn't callupdate_callback_dataifbot.cdc is None.Checklist for PRs
[ ] Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)[ ] Added myself alphabetically toAUTHORS.rst(optional)[ ] Added new classes & modules to the docs and all suitable__all__s