Reduce code duplication in testing defaults handling#3419
Conversation
harshil21
left a comment
There was a problem hiding this comment.
I'm definitely for splitting up non-fixture things from conftest to this new directory. In fact, can you also extract the nested functions inside check_defaults_handling into new functions (maybe in the same file)? Would make the code in there more readable at least
Those functions are nested because they work with several of the variables defined within |
|
@Bibo-Joshi hmm alright then I'm okay with it as is |
harshil21
left a comment
There was a problem hiding this comment.
Great, I can verify if this works only after this is merged to master, but the tests passing here are a good indication it will.
Closes #3414. I double checked that tests do fail if any of the defaults-handling logic in
tg.Botis removed.get_meafter each assertion or even after checkingget_mevia mocking it.tests/auxilwith a filebot_methods_checks.pyin it where I moved the respective functions fromconftest.pyto. If this finds approval, I would move all other non-fixture things fromconf.pyinto separate files withintests/auxil.