Merged
Conversation
Also add their tests
etc: Change a fixture scope to module, group WriteAccessAllowed test in a class
Bibo-Joshi
requested changes
Dec 31, 2022
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Awesome PR, thanks for being so quick! In addition to a few specific comments:
- in
test_inputmedia.pyit would be good if we added a test toTestSendMediaGroupabout sending with spoiler - similar for
test_{photo, video, animation}
Member
Author
we already test spoilers in |
Member
ah, no, I'm just blind :D |
# Conflicts: # telegram/_forumtopic.py
# Conflicts: # telegram/_files/inputmedia.py # telegram/ext/filters.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New API update
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added myself alphabetically toAUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-onlyAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idFor newMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idInCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
Added new constants attelegram.constantsand shortcuts to them as class variablesAdd new message types toMessage.effective_attachmentAdded new handlers for new update typesAdd the handlers to the warning loop in theConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOAdded logic for arbitrary callback data intg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message