Conversation
Bibo-Joshi
reviewed
Feb 1, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Left two nitpicks, but the rest LGTM :) Nice follow-up PR!
Member
Author
Done. This is the first time I ever changed a GH action, but looks like it works :) |
harshil21
approved these changes
Feb 2, 2023
Bibo-Joshi
reviewed
Feb 2, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Can you maybe add a README.md to tests/docs/ stating that
- that dir contains tests that cover our own scripting logic for the docs
- running
pytestusually doesn't include that due to the missingtest_prefix
?
Member
Author
Done |
Bibo-Joshi
added a commit
that referenced
this pull request
Feb 5, 2023
…3515, #3523, #3498, #3529) Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Shivam Saini <51438830+shivamsn97@users.noreply.github.com> Co-authored-by: Aditya Yadav <adityayadav11082@gmail.com> Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com> Co-authored-by: Crsi <47722349+CrsiX@users.noreply.github.com> Co-authored-by: poolitzer <github@poolitzer.eu> Co-authored-by: Aditya <clot27@apx_managed.vanilla>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds tests for functionality introduced in #3501 that resolved #3496
the tests are meant to only run in GH actions before building docs. They are not included in the main test suite, one of the reasons being that Python 3.9+ is required to run the admonition generator.