Conversation
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
|
After a bit of trial and error, I figured out that the windows test fail due to the usage of This may give false warnings in rare cases where The benefit of this change is that |
|
Good work! It looks good to me. |
Poolitzer
left a comment
There was a problem hiding this comment.
Such a small change, such a big test :D
Code looks good!
Supersedes #3538. Closes #3536
Checklist for PRs
[x] Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__s