Conversation
harshil21
reviewed
Feb 12, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
Nice work cleaning up the tests structure. Maybe worth doing these as well:
- Adding the
ext,inline,passportfolders in the tests so we can shift related test files in there. I believe they can have their ownconftests as well if that helps in better organizing it
Member
Author
I guess then it would make sense to mimic the whole directory structure of |
conftest to tests/auxil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #3420