Conversation
and fix what ruff found
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Regarding the several changed comparisons: I guess that ruff doesn't like hardcoded values there. However, I see no value of something like
const = 5
if something == const:
...especially if the comparison is part of a function. The definition of const should at the very least be moved outside of the function definition to avoid defining it on every run.
I don't really like it either.. do you want to ignore it? |
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Soooo many changes in the tests 😮
Makes ruff use more checkers, so we can now remove pyupgrade and isort from pre-commit hooks.
New checkers used:
isort
pylint
pyupgrade
ruff's checkers
flake8-use-pathlib
flake8-bugbear
flake8-comprehensions
flake8-pie
flake8-pytest-style
flake8-return
flake8-simplify
flake8-raise
flake8-logging-format
flake8-implicit-str-concat
TODO: Remove the ruff noqa line from test_official after api 6.6 is merged