Conversation
…am-bot into customized-concurrent-handling
…am-bot into customized-concurrent-handling
harshil21
left a comment
There was a problem hiding this comment.
initial review. Will review again after tests are added, implementation looks ok to me
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! This will come out great :) I left a bunch of new comments, but nothing major IMO.
…am-bot into customized-concurrent-handling
harshil21
left a comment
There was a problem hiding this comment.
more comments. But looking much more refined now 👍🏽
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the new updates! I left smaller comments :) Also the docs build is failing …
Regarding the unit tests on the update processors: TBH I don't see them going in a right direction and I'm not sure how I can explain better what should be covered. I will try and write some tests myself, but please do feel free to ask anything about that if you have questions :)
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM :) @harshil21 do you have anything to add?
After merge, the dev-wiki should be updated to
- elaborate on the new processor on the page on concurrency
- mention the
BaseUpdateProcessoron the architecture page. This would be a good chance to convert the graphic to a mermaid diagram
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
|
Big thanks to @clot27 for your work and also your patience! 👏 |
Closes #3509 when done.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)[ ] Added myself alphabetically toAUTHORS.rst(optional)__all__s