Merged
Conversation
This was referenced Jun 2, 2023
Bibo-Joshi
commented
Jun 3, 2023
clot27
added a commit
that referenced
this pull request
Jul 3, 2023
…#3764, #3762, #3759) Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Luca Bellanti <luca.bellanti@gmail.com> Co-authored-by: thefunkycat <104379699+thefunkycat@users.noreply.github.com> Co-authored-by: Aditya Yadav <69784758+clot27@users.noreply.github.com> Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Python 3.7 reaches EOL at the end of this month, it's time to say goodbye.
Before merging this PR, we should try to include as many py3.8-only features as reasonably possible without too much delay. This includes the following issues:
missing_okParameter #3730CancelledErroris a subclass ofBaseException#3731PicklePersistence#3732PRs to mention:
missing_okParameter #3742PicklePersistence#3740CancelledError#3754@final,FinalandLiteral#3753Literal, causing tests/docs to fail #3764nametoasyncio.create_task#3759