Remove Python 3.7 workaround for PicklePersistence#3740
Merged
Bibo-Joshi merged 5 commits intodrop-py-37from Jun 9, 2023
Merged
Remove Python 3.7 workaround for PicklePersistence#3740Bibo-Joshi merged 5 commits intodrop-py-37from
PicklePersistence#3740Bibo-Joshi merged 5 commits intodrop-py-37from
Conversation
Bibo-Joshi
reviewed
Jun 4, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
I guess the tests don't have explicit cases for py 3.7, right. Howover, I am wondering if it is possible to pickle data in 3.7 and unpickle it in 3.8 🤔 Could you check?
Bibo-Joshi
approved these changes
Jun 7, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Changes LGTM 👍 Did you have any chance to test if py37-pickled files can be loaded in py38?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3732
I don't think anything in tests need to change?