Add walrus operator wherever possible#3749
Add walrus operator wherever possible#3749Bibo-Joshi merged 3 commits intopython-telegram-bot:drop-py-37from
Conversation
|
@Bibo-Joshi @clot27 is there a reason the |
|
Thanks for the PR! The tests are failing on some other PRs since yesterday, too. Seems like something changed in the TG servers. We'll have to investigate. |
Bibo-Joshi
left a comment
There was a problem hiding this comment.
The failing tests seem to have recovered. Now only TestInlineQueryHandler.test_context_pattern is failing. I guess that's due to your changes though TBH I don't really see a flaw in those … Would you mind double check ing that?
|
@Bibo-Joshi should be fixed now :) Edit: oof the tests still fail but this is related to submitting the test coverage, all the tests pass. so not the code. |
|
Thank you very much for the nice contribution :) |
Solves #3734
I have tried to add the walrus operator wherever possible.
I went through most files.
There were a couple more instances I found where I could have added it, but it was unnecessary and would not have necessarily improved readability or code quality.
I was more lenient when it came to adding the walrus operator to tests