entities add#375
Closed
evstratbg wants to merge 1 commit intopython-telegram-bot:masterfrom
evstratbg:patch-2
Closed
entities add#375evstratbg wants to merge 1 commit intopython-telegram-bot:masterfrom evstratbg:patch-2
evstratbg wants to merge 1 commit intopython-telegram-bot:masterfrom
evstratbg:patch-2
Conversation
Telegram's update message has new entities, described here https://core.telegram.org/bots/API#messageentity I've added some, and fix command, according to docs. If bot receives smth like test@test.com /start, update has such tuple: 'entities': [{'length': 12, 'offset': 0, 'type': 'email'}, {'length': 5, 'offset': 0, 'type': 'bot_command'}] which is neither a bot_command nor an email Still, devs can parse an entity, using indexes of the dicts and a length in an entity list
Member
|
Hey, thank you for your contribution! I'm wondering, you only accept the message if there is only one entity in the message... that could be confusing (at least to me it is). Wouldn't it be more intuitive to check if any of the entities is the one we are searching for? Another thing: Could we then perhaps have some kind of higher-order function that you can use like this_ def entities(list_of_entities):
# return a new function that checks the message for those entitiesand then MessageHandler([entities(MENTION, TEXT_MENTION)])What do you think? |
jsmnbom
added a commit
that referenced
this pull request
Sep 13, 2016
Should ideally superseed #375.
Merged
Member
|
Superseeded by #409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telegram's update message has new entities, described here https://core.telegram.org/bots/API#messageentity
I've added some, and fix command, according to docs.
If bot receives smth like test@test.com /start, update has such tuple:
'entities': [{'length': 12, 'offset': 0, 'type': 'email'}, {'length': 5, 'offset': 0, 'type': 'bot_command'}]
which is neither a bot_command nor an email
Still, devs can parse an entity, using indexes of the dicts and a length in an entity list