fix error with Literal, causing tests/docs to fail#3764
Merged
Bibo-Joshi merged 1 commit intodrop-py-37from Jun 19, 2023
Merged
fix error with Literal, causing tests/docs to fail#3764Bibo-Joshi merged 1 commit intodrop-py-37from
Literal, causing tests/docs to fail#3764Bibo-Joshi merged 1 commit intodrop-py-37from
Conversation
harshil21
approved these changes
Jun 18, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
docs successfully built locally for me
Bibo-Joshi
reviewed
Jun 18, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Can you maybe extend the CSI comment about why Literal needs to be treated here as well?
Member
Author
To me, it looks rather natural in this sequence and it might look a bit strange if I explain only the (
"<class 'typing._GenericAlias'>",
"<class 'types.GenericAlias'>",
"<class 'typing._LiteralGenericAlias'>",
)They're all Generic aliases. OTOH, it's hard to imagine that we'll ever put a telegram class inside a literal. Something like: Persistence = Literal["PicklePersistence", "DictPersistence"]In this case, I could just create a separate condition for |
Seonzzang2
added a commit
to Seonzzang2/python-telegram-bot
that referenced
this pull request
Jun 20, 2023
…telegram-bot#3764)" This reverts commit 27a8683.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test failure caused by introduction of
Literaltypes.