Conversation
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've left a few comments. IISC the only mismatch with the Bot API left is the arguments of PollAnswer becoming optional.
In addition to adding the new functionality, we must also remove all deprecations & backward compatibility layers we introduced for API 6.7, in accordance to our stability policy. This should be done in a separate PR IMO. Still, I'm adding it to the checklist for completeness.
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! :)
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Found one more item in the checklist - otherwise I'm happy :)
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM, then :) @clot27 @harshil21 do you have anything to add? @lemontree210 @Poolitzer do you want to review as well?
Poolitzer
left a comment
There was a problem hiding this comment.
And we should change the int attribute to datetime as well hmmm.
Do we have other empty classes trigger attachment? Because this feels wrong to me tbh.
There was a problem hiding this comment.
Nice backwards compatibility change
|
@Poolitzer Uff how did we miss that. Yes the expiration date need to be converted to datetime. |
Checklist
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__AUTHORS.rst(optional)__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorIf the PR contains API changes (otherwise, you can ignore this passage)
Checked the Bot API specific sections of the
Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_New classes:
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-onlyAdded new shortcuts:
~telegram.Chat& :class:~telegram.Userfor all methods that acceptchat/user_id~telegram.Messagefor all methods that acceptchat_idandmessage_id~telegram.Messageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id~telegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachment~telegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOtelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/contains :class:~telegram.Message