Conversation
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the nice PR! I left some comments below :)
One (unrelated) thing that I noticed is that Bot.__eq__ doesn't comply with the documentation of TelegramObject.__eq__, i.e. it doesn't fall back to super().__eq__. Since so for Bot.__eq__ is not explicitly documented, it might be wise to adjust this before adding documentation would make this a (very minor) breaking change. What do you think?
cc @Poolitzer @harshil21
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! Just two smaller comments below :) What dou you think about #3929 (review) ?
harshil21
left a comment
There was a problem hiding this comment.
Since so for Bot.eq is not explicitly documented, it might be wise to adjust this before adding documentation would make this a (very minor) breaking change. What do you think?
I agree, should be updated, though we will need to add an _id_attrs for Bot as well, what should that include?
Also telegram.ext.updater.rst still has the :special-members: in it, should be deleted.
Also I believe that a side effect of adding the special-members derivative in the conf.py file was that now we have all these extra documented methods (see BaseFilter docs):

I see that there is also |

Closes #3926